Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): Hide suggestion banner on password fields 🍒 🏠 #12466

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix(android): Hide suggestion banner on password fields 🍒 🏠 #12466

merged 1 commit into from
Sep 25, 2024

Conversation

darcywong00
Copy link
Contributor

🍒 pick of #12442 for stable-17.0

This adds a check in System Keyboard to disable suggestion banner on certain fields (e.g. password field)

User Testing

  • Setup - Install the PR build of Keyman for Android on an Android device/emulator

  • TEST_BANNER_DISABLED_ON_PASSWORD - Verifies suggestion banner is disabled on certain fields

  1. Launch Keyman for Android
  2. On the Get Started menu, set Keyman as the default system keyboard
  3. Launch Chrome and select a text area
  4. With Keyman selected as the system keyboard, verify the OSK displays suggestions as you type
  5. On Chrome, go to a page with password fields (e.g. https://darcywong00.github.io/examples/form.html). That page is small so you may need to zoom in
  6. On the test page, select the "Visible Text Field"
  7. Verify the OSK displays suggestions as you type
  8. On the test page, select the "Password Field"
  9. Verify the OSK disables suggestions (replaced with the Keyman banner) as you type
  10. On the test page, select "Search Field"
  11. Verify the OSK re-enables suggestions as you type

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Sep 25, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Sep 25, 2024 •
edited
Loading

User Test Results

Test specification and instructions

  • ✅ TEST_BANNER_DISABLED_ON_PASSWORD (PASSED) (notes)

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot changed the title fix(android): Hide suggestion banner on password fields 🍒 fix(android): Hide suggestion banner on password fields 🍒 🏠 Sep 25, 2024
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S11 milestone Sep 25, 2024
@github-actions github-actions bot added android/ android/engine/ cherry-pick Change already merged into another (stable) branch fix labels Sep 25, 2024
@dinakaranr
Copy link

Test Results

I tested this issue with the attached "Keyman 17.0.331-alpha-test-12466" build on the Android 14 and Android 12 mobile. Here is my observation.

  • TEST_BANNER_DISABLED_ON_PASSWORD (Passed):
  1. Installed the "Keyman-17.0.331.apk" file from the PR build. and gave all permissions to the application.
  2. Checked the "Enable Keyman as system-wide keyboard" on the settings page. Checked the "Set Keyman as default keyboard".
  3. Open the Keyman app. Enter some text in the keyman's notepad.
  4. Launch the Chrome browser. Navigate the "editpad.org" website and enter some text on the page.
  5. Verified that the suggestion banner appeared and showed suggestions on the Keyman banner.
  6. Open a new tab and go to the https://darcywong00.github.io/examples/form.html page.
  7. Verified the test page appeared.
  8. Select the "Visible Text Field"
  9. Verified the OSK displays suggestions when typing text.
  10. Select the "Password Field"
  11. Verified the OSK disabled suggestions and it is showing the "Keyman banner" OSK
  12. Select the "Search Field"
  13. Verified the OSK re-enabled suggestions when typing text.
    It works great for me. Thank you.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Sep 25, 2024
@darcywong00 darcywong00 merged commit 3084f11 into stable-17.0 Sep 25, 2024
6 checks passed
@darcywong00 darcywong00 deleted the cherrypic/android/12442-disable-banner-password branch September 25, 2024 22:51
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@sgschantz sgschantz Awaiting requested review from sgschantz sgschantz is a code owner

Assignees
No one assigned
Labels
android/engine/ android/ cherry-pick Change already merged into another (stable) branch fix has-user-test stable
Projects
Keyman
Archived in project
Milestone
A18S11
Development

Successfully merging this pull request may close these issues.
4 participants
@darcywong00 @dinakaranr @keyman-server @mcdurdin